[Asterisk-code-review] res pjsip pubsub: Add more locking and checking around termi... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip_pubsub: Add more locking and checking around terminates
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/#/c/3018/2/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 2332: 	if (sub->tree->last_notify) {
> You are mixing the usage of last_notify.  It was originally used as a boole
Yep. Problem?


Line 3341: 	if (!(sub_tree->evsub && sub_tree->dlg)) {
> This is an awkward expression.  Why not distribute the ! operator and reduc
It's microscopically faster. :)


Line 3455: 	if (!(sub_tree->evsub && sub_tree->dlg)) {
> There is no need to avoid caching sub_tree->dlg in a local variable.
I said it was overkill.  I'll remove them if you want.


-- 
To view, visit https://gerrit.asterisk.org/3018
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I779d11802cf672a51392e62a74a1216596075ba1
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes