[Asterisk-code-review] Implement deaf mode for confbridge (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: Implement deaf mode for confbridge
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/2933/2/main/bridge_channel.c
File main/bridge_channel.c:

PS2, Line 975: 	if (fr->frametype == AST_FRAME_VOICE &&
             : 	    (bridge_channel->features && bridge_channel->features->deaf)) {
             : 		short buf[fr->samples];
             : 		struct ast_frame sframe = {
             : 			.frametype = AST_FRAME_VOICE,
             : 			.subclass.format = ast_format_slin,
             : 			.data.ptr = buf,
             : 			.samples = fr->samples,
             : 			.datalen = sizeof(buf),
             : 		};
             : 		memset(buf, 0, sizeof(buf));
             : 		dup = ast_frdup(&sframe);
             : 	} else {
             : 		dup = ast_frdup(fr);
             : 	}
> I suppose yes, I remember copying this code from some existing module back 
Take a look at/search for ast_channel_start_silence_generator and it's counter part ast_channel_stop_silence_generator. One example can be found in 'res/stasis/control.c'

I'm thinking you can start the generator from the conf_bridge code when a user is deafened and stop when undeafened. If so then you won't need the bridging changes.


-- 
To view, visit https://gerrit.asterisk.org/2933
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2628bdda080fd2b1e914212de50dd26de9d3e96
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Timo Teräs <timo.teras at iki.fi>
Gerrit-HasComments: Yes