[Asterisk-code-review] core: Not the configured but granted number of possible file... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: core: Not the configured but granted number of possible file descriptors.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2969/2/main/asterisk.c
File main/asterisk.c:

PS2, Line 625: 		status = errno;
             : 		ast_cli(a->fd, "  Maximum open file handles:   Error because of %s\n", strerror(status));
There is no need to set the status variable with errno.  You can simply do strerror(errno).  Also you don't even need the status variable at all since you can just do:

if (getrlimit(RLIMIT_NOFILE, &limits)) {
  ast_cli(a->fd, "  Max...\n", strerror(errno));
} else if () {
} else {
}


-- 
To view, visit https://gerrit.asterisk.org/2969
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2df5c58863b5007b34b77adbe28b885dfcdf7e0b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes