[Asterisk-code-review] ARI: Ensure proper channel state on operations. (asterisk[master])

Mark Michelson asteriskteam at digium.com
Thu Jun 9 14:44:38 CDT 2016


Mark Michelson has uploaded a new patch set (#3).

Change subject: ARI: Ensure proper channel state on operations.
......................................................................

ARI: Ensure proper channel state on operations.

ARI was recently outfitted with operations to create and dial channels.
This leads to the ability to try funny stuff. You could create a channel
and then immediately try to play back media on it. You could create a
channel, dial it, and while it is ringing attempt to make it continue in
the dialplan.

This commit attempts to fix this by adding a channel state check to
operations that should not be able to operate on outbound channels that
have not yet answered. If a channel is in an invalid state, we will send
a 412 response.

ASTERISK-26047 #close
Reported by Mark Michelson

Change-Id: I2ca51bf9ef2b44a1dc5a73f2d2de35c62c37dfd8
---
M res/ari/resource_channels.c
M res/res_ari_channels.c
M res/res_ari_recordings.c
M rest-api/api-docs/channels.json
4 files changed, 196 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/26/2926/3
-- 
To view, visit https://gerrit.asterisk.org/2926
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ca51bf9ef2b44a1dc5a73f2d2de35c62c37dfd8
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list