[Asterisk-code-review] cel: Ensure only one dial status per channel exists. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: cel: Ensure only one dial status per channel exists.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2972/3/main/cel.c
File main/cel.c:

Line 1264: 		if (!strcmp(dialstatus_string, "ANSWER") && strcmp(dialstatus->dialstatus, "ANSWER")) {
is_valid_dialstatus() uses strcasecmp


PS3, Line 1271: 		} else {
              : 			ao2_ref(dialstatus, -1);
              : 			return;
dial_statuses is ref leaked here


-- 
To view, visit https://gerrit.asterisk.org/2972
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5944eb923db17b6a0faa7317ff6abc9307c009fe
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes