[Asterisk-code-review] test http media cache: Fix failing test. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu Jun 9 13:38:40 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: test_http_media_cache: Fix failing test.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Minor nit

https://gerrit.asterisk.org/#/c/2974/1/tests/test_http_media_cache.c
File tests/test_http_media_cache.c:

PS1, Line 74: 			(int) (expected) + (delta), actual_expires, \
            : 			(int)  (expected) - (delta), actual_expires); \
You want to cast the expression expected +/- delta not just the expected value to an int:  (int) ((expected) +/- (delta))

Also you have two spaces between the cast and expression in the second line.


-- 
To view, visit https://gerrit.asterisk.org/2974
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a0e10722c1c5d276d5a4d6a67136d6ec26c247
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list