[Asterisk-code-review] cdr.c: Remove assert in base process dial end (asterisk[master])

[George Joseph]

George Joseph has uploaded a new change for review.

  https://gerrit.asterisk.org/3002

Change subject: cdr.c: Remove assert in base_process_dial_end
......................................................................

cdr.c: Remove assert in base_process_dial_end

Scenario: Caller blonde transfer
Bob calls Charlie who answers.
Bob puts Charlie on hold and calls Alice.
Before Alice answers, Bob transfers Charlie to Alice.

Charlie's channel triggers an assert because he gets an "ANSWERED"
event even though he never dialed anything. With recent changed to dial
events, this is now a valid scenario so the assert needed to be removed.

ASTERISK-26103 #close

Change-Id: I2679b517b696e7952ab7fb29403df9140e7d1de2
---
M main/cdr.c
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/02/3002/1

diff --git a/main/cdr.c b/main/cdr.c
index b43e361..8658710 100644
--- a/main/cdr.c
+++ b/main/cdr.c
@@ -1415,8 +1415,6 @@
 
 static int base_process_dial_end(struct cdr_object *cdr, struct ast_channel_snapshot *caller, struct ast_channel_snapshot *peer, const char *dial_status)
 {
-	/* In general, most things shouldn't get a dial end. */
-	ast_assert(0);
 	return 0;
 }
 

-- 
To view, visit https://gerrit.asterisk.org/3002
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2679b517b696e7952ab7fb29403df9140e7d1de2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>