[Asterisk-code-review] format ogg speex: Add support for OGG/Speex file format. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: format_ogg_speex: Add support for OGG/Speex file format.
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

Just minor coding guidelines thing, but this should also be added to the CHANGES file.

https://gerrit.asterisk.org/#/c/2939/3/formats/format_ogg_speex.c
File formats/format_ogg_speex.c:

Line 75: 		if (result < 0)
Coding guidelines - should still be in a { }


Line 106: 			if (result < 0)
Coding guidelines - should still be in a { }


Line 115: 			if (bytes == 0)
Coding guidelines - should still be in a { }


Line 198: 	if (hdr)
Coding guidelines - should still be in a { }


Line 228: 	if (read_packet(fs) < 0)
Coding guidelines - should still be in a { }


-- 
To view, visit https://gerrit.asterisk.org/2939
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98518bd28fc8f95668b3fe27d2cab45045ff3f7a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes