[Asterisk-code-review] cel: Ensure only one dial status per channel exists. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: cel: Ensure only one dial status per channel exists.
......................................................................


Patch Set 2:

The code itself looks good, but I'm not sure I understand why we go with the first saved dialstatus. Wouldn't it make sense to make the final dial status the one that is reported? I'm considering the situation in the linked ASTERISK issue.

* Bob calls a queue.
* The queue rings Alice.
* Alice doesn't answer.
* The queue publishes NOANSWER.
* CEL saves the NOANSWER status for Bob.
* The queue waits a bit and dials Alice again.
* Alice answers the call.
* The queue publishes ANSWER.

At this point, with your proposed patch, CEL would ignore the ANSWER state in preference of the first one. However, I feel like we would be saving an incorrect dial state since the call was ultimately answered.

-- 
To view, visit https://gerrit.asterisk.org/2972
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5944eb923db17b6a0faa7317ff6abc9307c009fe
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No