[Asterisk-code-review] Fix #include poll.h and sys/cdefs.h (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged.

Change subject: Fix #include poll.h and sys/cdefs.h
......................................................................


Fix #include poll.h and sys/cdefs.h

POSIX defines poll.h, sys/poll.h should not be used at is c-library
internal header which may or may not exist. Notable in musl it
generates warning of being incorrect. And add explict include of
sys/cdefs.h where needed.

Change-Id: I142930df53fe7585a06b854b6faddc5301e024be
---
M include/asterisk/compat.h
M include/asterisk/poll-compat.h
M main/ast_expr2.c
M main/ast_expr2.y
4 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Mark Michelson: Looks good to me, but someone else must approve
  Matthew Fredrickson: Looks good to me, approved
  Joshua Colp: Looks good to me, but someone else must approve; Verified



diff --git a/include/asterisk/compat.h b/include/asterisk/compat.h
index 3eb6c96..252ce91 100644
--- a/include/asterisk/compat.h
+++ b/include/asterisk/compat.h
@@ -70,7 +70,7 @@
 #endif
 
 #ifndef AST_POLL_COMPAT
-#include <sys/poll.h>
+#include <poll.h>
 #else
 #include "asterisk/poll-compat.h"
 #endif
diff --git a/include/asterisk/poll-compat.h b/include/asterisk/poll-compat.h
index cbb6109..72ac2c3 100644
--- a/include/asterisk/poll-compat.h
+++ b/include/asterisk/poll-compat.h
@@ -83,7 +83,7 @@
 
 #ifndef AST_POLL_COMPAT
 
-#include <sys/poll.h>
+#include <poll.h>
 
 #define ast_poll(a, b, c) poll(a, b, c)
 
diff --git a/main/ast_expr2.c b/main/ast_expr2.c
index d41072d..c700b01 100644
--- a/main/ast_expr2.c
+++ b/main/ast_expr2.c
@@ -94,6 +94,7 @@
 #define ASTMM_LIBC ASTMM_REDIRECT
 #include "asterisk.h"
 
+#include <sys/cdefs.h>
 #include <sys/types.h>
 #include <stdio.h>
 
diff --git a/main/ast_expr2.y b/main/ast_expr2.y
index 762e83d..df87bcc 100644
--- a/main/ast_expr2.y
+++ b/main/ast_expr2.y
@@ -15,6 +15,7 @@
 #define ASTMM_LIBC ASTMM_REDIRECT
 #include "asterisk.h"
 
+#include <sys/cdefs.h>
 #include <sys/types.h>
 #include <stdio.h>
 

-- 
To view, visit https://gerrit.asterisk.org/2934
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I142930df53fe7585a06b854b6faddc5301e024be
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>