[Asterisk-code-review] taskprocessors: Implement high/low water mark alerts. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: taskprocessors: Implement high/low water mark alerts.
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/#/c/2952/2/main/taskprocessor.c
File main/taskprocessor.c:

Line 567: 		&& !old != !tps_alert_count) {
My brain is going to melt.


https://gerrit.asterisk.org/#/c/2952/2/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

PS2, Line 409: 			if (ast_taskprocessor_alert_get()) {
             : 				/* We're overloaded, ignore the unmatched response. */
             : 				return PJ_TRUE;
             : 			}
This will cause us to ignore SIP requests if ANY task processor is above a high-water mark. It seems odd/wrong to me that we would pause SIP messages due to a potentially completely unrelated taskprocessor being lagged/deadlocked.

Also, I suggest adding a debug message here so that if we're investigating an issue, we can see that incoming SIP responses were being ignored due to taskprocessor high-water mark alerts.


PS2, Line 428: 		if (ast_taskprocessor_alert_get()) {
             : 			/*
             : 			 * When taskprocessors get backed up, there is a good chance that
             : 			 * we are being overloaded and need to defer adding new work to
             : 			 * the system.  To defer the work we will ignore the request and
             : 			 * rely on the peer's transport layer to retransmit the message.
             : 			 * We usually work off the overload within a few seconds.  The
             : 			 * alternative is to send back a 503 response to these requests
             : 			 * and be done with it.
             : 			 */
             : 			return PJ_TRUE;
             : 		}
Same comment here as well.


-- 
To view, visit https://gerrit.asterisk.org/2952
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I182f1be603529cd665958661c4c05ff9901825fa
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes