[Asterisk-code-review] res pjsip pubsub.c: Use distributor serializer for incoming ... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_pubsub.c: Use distributor serializer for incoming subscriptions.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/2949/2/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 1251: 		sub_tree->serializer = ast_sip_get_distributor_serializer(rdata);
> Is ast_threadpool_serializer_get_current() an option here? If it is, there'
I initially was thinking of using that function but decided to avoid it in favour of picking the serializer from the rdata information just like the distributor.  That way I'm guaranteed to be getting the expected serializer rather than risking getting no serializer or the wrong one if for some reason we are not executing under the distributor's serializer at this time.


-- 
To view, visit https://gerrit.asterisk.org/2949
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18b00bb74a56747b2c8c29543a82440b110bf0b0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes