[Asterisk-code-review] chan sip: bigger buffers for headers, better failure mode (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: chan_sip: bigger buffers for headers, better failure mode
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

Couple minor issues I see now then I think it'll be ready to go.

https://gerrit.asterisk.org/#/c/2923/4/channels/chan_sip.c
File channels/chan_sip.c:

Line 14269: 		ast_log(LOG_ERROR, "The From header was truncated in call '%s'. This call setup will probably fail.\n", p->callid);
Lets get rid of the word 'probably'.  Maybe improve the message as such:
ast_log(LOG_ERROR, "The From header could not be allocated for call '%s'.  This call setup will fail.\n", p->callid);


Line 14290: 			/* needed again, as ast_str_make_space coud've changed the pointer */
from_buf isn't used in the above scope so it should be declared / initialized here instead.


Line 14357: 		ast_log(LOG_ERROR, "The To header was truncated in call '%s'. This call setup will probably fail.\n", p->callid);
Same comment as with error allocating the From header.


-- 
To view, visit https://gerrit.asterisk.org/2923
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b68fcbddca6f6cc7d7a92fe1cb0d5430282b2b3
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Vasil Kolev <vasil.kolev at securax.org>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Vasil Kolev <vasil.kolev at securax.org>
Gerrit-HasComments: Yes