[Asterisk-code-review] Fix to include signal.h (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Jun 7 05:06:09 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: Fix to include signal.h
......................................................................


Patch Set 1: Code-Review-1

(9 comments)

https://gerrit.asterisk.org/#/c/2937/1/addons/chan_ooh323.h
File addons/chan_ooh323.h:

Line 41: #include <signal.h>
Double include.


https://gerrit.asterisk.org/#/c/2937/1/apps/app_dahdiras.c
File apps/app_dahdiras.c:

PS1, Line 39: #ifdef __linux__
            : #include <signal.h>
            : #else
            : #include <signal.h>
            : #endif /* __linux__ */
This ifdef is not needed now.


https://gerrit.asterisk.org/#/c/2937/1/channels/chan_dahdi.c
File channels/chan_dahdi.c:

PS1, Line 61: #include <signal.h>
            : #else
            : #include <signal.h>
            : #endif
signal.h can always be included now


https://gerrit.asterisk.org/#/c/2937/1/channels/chan_iax2.c
File channels/chan_iax2.c:

Line 71: #include <signal.h>
Double.


https://gerrit.asterisk.org/#/c/2937/1/channels/chan_mgcp.c
File channels/chan_mgcp.c:

Line 50: #include <signal.h>
Double.


https://gerrit.asterisk.org/#/c/2937/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 227: #include <signal.h>
Double


https://gerrit.asterisk.org/#/c/2937/1/channels/chan_skinny.c
File channels/chan_skinny.c:

Line 52: #include <signal.h>
Double


https://gerrit.asterisk.org/#/c/2937/1/main/cli.c
File main/cli.c:

Line 45: #include <signal.h>
Double


https://gerrit.asterisk.org/#/c/2937/1/main/tcptls.c
File main/tcptls.c:

Line 41: #include <signal.h>
Double


-- 
To view, visit https://gerrit.asterisk.org/2937
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia56b0aa1d84b5c590114867b1b384a624f39a6fc
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list