[Asterisk-code-review] res odbc: Implement a connection pool. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_odbc: Implement a connection pool.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2943/1/res/res_odbc.c
File res/res_odbc.c:

PS1, Line 881: 	if ((res = SQLFreeHandle(SQL_HANDLE_DBC, con)) == SQL_SUCCESS) {
             : 		ast_debug(3, "Database handle %p (connection %p) deallocated\n", obj, con);
             : 	} else {
             : 		SQLGetDiagRec(SQL_HANDLE_DBC, con, 1, state, &err, msg, 100, &mlen);
             : 		ast_log(LOG_WARNING, "Unable to deallocate database handle %p? %d errno=%d %s\n", con, res, (int)err, msg);
             : 	}
> Somewhat outside the scope of this change (or if Asterisk would even care),
I would say stuff is really going off the rails if that happens... and I'm not sure how we'd recover.


-- 
To view, visit https://gerrit.asterisk.org/2943
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6774bf4bac49a0b30242c76a09c403d2e856ecff
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes