[Asterisk-code-review] ARI: Ensure proper channel state on operations. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Jun 6 06:17:44 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: ARI: Ensure proper channel state on operations.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2926/1/res/ari/resource_channels.c
File res/ari/resource_channels.c:

PS1, Line 89: 	if (snapshot->state == AST_STATE_DOWN
            : 		|| snapshot->state == AST_STATE_RESERVED
            : 		|| snapshot->state == AST_STATE_RINGING) {
For inbound channels what state are they in, does this break them for certain operations? Add a comment about why not.


-- 
To view, visit https://gerrit.asterisk.org/2926
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca51bf9ef2b44a1dc5a73f2d2de35c62c37dfd8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list