[Asterisk-code-review] translate: Enables native Packet-Loss Concealment (PLC) for ... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs.
......................................................................


Patch Set 15: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1820/15/main/translate.c
File main/translate.c:

PS15, Line 636: tmp = step->t->frameout(step);
frameout can return NULL.

Therefore, tmp could be NULL and should not be added to inner_head, because NULL frames do not have a next to add the next output.
Therefore, inner_last could be NULL and inner_head should be NULL, because the current step did not create any output.
Therefore, the translation has no input for the next step and should stop.
Therefore, the frame might not create output and should not be added to out, because NULL frames do not have a next to add the next output.


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 15
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes