[Asterisk-code-review] core/manager: Add uptime field to FullyBooted (asterisk[master])
Mark Michelson
asteriskteam at digium.com
Wed Jun 1 15:38:01 CDT 2016
Mark Michelson has posted comments on this change.
Change subject: core/manager: Add uptime field to FullyBooted
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.asterisk.org/#/c/2904/3/main/asterisk.c
File main/asterisk.c:
PS3, Line 1043: "Uptime", (int) uptime.tv_sec,
: "LastReload", (int) lastreloaded.tv_sec);
It looks like uptime and lastreloaded could be used uninitialized here.
https://gerrit.asterisk.org/#/c/2904/3/main/manager.c
File main/manager.c:
PS3, Line 4174: "Uptime: %ld\r\n"
: "LastReload: %ld\r\n"
: "Status: Fully Booted\r\n\r\n", cat_str, (long) uptime.tv_sec, (long) lastreloaded.tv_sec);
: }
It looks like uptime and lastreloaded could potentially be used uninitialized here.
--
To view, visit https://gerrit.asterisk.org/2904
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I909b330801c0990d78df9b272ab0adc95aecb15e
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list