[Asterisk-code-review] res pjsip: improve realtime performance #2 (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip: improve realtime performance #2
......................................................................


Patch Set 1:

> Additionally the trouble with putting an endpoint on a contact is
 > that multiple contacts can reference the same AOR, and thus same
 > contact. That's why it's not persisted.

I don't understand the relationship model for objects: endpoints, aors, contacts.
I think the relations should be
 - contact references to aor,
 - aor references to endpoint
In this case we can easy find endpoint if we know only contact.
Now it's so complicated... look at function find_an_endpoint in pjsip_options.c
And what's if there are many endpoints with the same aor?
This function returns one of them. But will it be correct endpoint?

-- 
To view, visit https://gerrit.asterisk.org/2906
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id324c1776fa55d3741e0c5457ecac0304cb1a0df
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No