[Asterisk-code-review] app voicemail: adds configuration options to set taskprocess... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_voicemail: adds configuration options to set taskprocessor alert levels
......................................................................


Patch Set 3: Code-Review-1

(7 comments)

https://gerrit.asterisk.org/#/c/3318/3//COMMIT_MSG
Commit Message:

Line 7: app_voicemail: adds configuration options to set taskprocessor alert levels
Long line.  Suggest:
app_voicemail: Add taskprocessor alert level options.


https://gerrit.asterisk.org/#/c/3318/3/CHANGES
File CHANGES:

PS3, Line 15: app_voicemail
            : ------------------
            :  * Added "tps_queue_high" and "tps_queue_low" options.
            :    The options can modify the taskprocessor alert levels for this module.
            :    Additional information can be found in the sample configuration file at
            :    config/samples/voicemail.conf.sample.
v13.11.0-rc1 has been created so this needs to go into a new v13.12.0 section.


https://gerrit.asterisk.org/#/c/3318/3/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 13456: 	long tps_queue_low, tps_queue_high;
I prefer one variable declaration per line.  It makes it easier to find and diffs smaller when you remove variables.
long tps_queue_low;
long tps_queue_high;


Line 14034: 			tps_queue_high = atoi(val);
use sscanf instead of atoi.  sscanf has better error detection (especially if zero is a valid value).


Line 14036: 				ast_log(AST_LOG_WARNING, "Invalid the taskprocessor high water alert trigger level '%s'. Using default value.\n", val);
guidelines: break long lines at 90

I don't think mentioning we are using the default is all that necessary since we have given a warning.

Probably shouldn't allow the high water level to be lower than the 500 default.


Line 14044: 				ast_log(AST_LOG_WARNING, "Invalid the taskprocessor low water clear alert level '%s'. Using default value.\n", val);
long line


https://gerrit.asterisk.org/#/c/3318/3/configs/samples/voicemail.conf.sample
File configs/samples/voicemail.conf.sample:

Line 387: ; tps_queue_low=450	; Taskprocessor low water clear alert level.
The default is 90% of high water level.


-- 
To view, visit https://gerrit.asterisk.org/3318
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I766294fbffedf64053c0d9ac0bedd3109f043ee8
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes