[Asterisk-code-review] pbx.c: Fix handling of '-' in extension name and callerid (asterisk[11])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: pbx.c: Fix handling of '-' in extension name and callerid
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/3353/3/main/pbx.c
File main/pbx.c:

Line 1556: 						ast_log(LOG_NOTICE,"Called from: %s:%d: The %s context records the exten %s (CID match: %s) but it is not in its root_table\n", file, line, c2->name, dummy_name, e1->cidmatch_display );
*puts on Richard hat*

Can you break up this line, please? It's so long that Gerrit won't display the whole thing (even after horizontal scrolling). It's probably a quirk of Gerrit/my browser, but I think that's probably a good indication that the line should be shortened.


Line 10074: 			if (strcmp(e->name, tmp->name)) {
Based on the commit message stating that the stripped fields should be used for comparison, should this be comparing e->exten and tmp->exten instead?


Line 10107: 			if (strcmp(e->name, tmp->name)) {
And here as well.


-- 
To view, visit https://gerrit.asterisk.org/3353
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cd61ce57acc1570ca6cc14960c4c3b0a9eb837f
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes