[Asterisk-code-review] dsp.c: Fix dsp.conf DTMF twist tolerance config options. (asterisk[11])

Richard Mudgett asteriskteam at digium.com
Tue Jul 26 14:38:49 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: dsp.c: Fix dsp.conf DTMF twist tolerance config options.
......................................................................


Patch Set 1: Code-Review-1

Feltercarb!  I've found several sources that say the row energy tolerance is up to 8dB higher than the column energy and the opposite twist is 4 dB.  There is inconsistency in the definition of normal/reverse twist but there is no inconsistency in the relative power level tolerances.

I'm going to have to rework this and the unit test patches.

This patch makes the default tolerances the wrong way.

-- 
To view, visit https://gerrit.asterisk.org/3335
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf97e3a72f1edc5fca58f2fa7b20785922be0cae
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list