[Asterisk-code-review] res pjsip mwi: fix unsolicited mwi blocks PJSIP stack (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip_mwi: fix unsolicited mwi blocks PJSIP stack
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.asterisk.org/#/c/3320/2/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 182: static struct ast_taskprocessor *get_mwi_serializer(void)
> delete extraneous blank line here
Done


Line 183: {
> guidelines curly location
Done


Line 1217: 	ast_sip_push_task(get_mwi_serializer(), send_initial_notify_all, NULL);
> Leave this one going to the pjsip/default serializer.  This way it will not
I think the MWI is low priority task.
My point is to avoid any delay on main SIP stack (pjsip/default serializer) which is used for REGISTER/INVITE.
The send_initial_notify_all shouldn't delay any main SIP stack tasks too.
I think it's better to interfere with MWI than main SIP stack.


-- 
To view, visit https://gerrit.asterisk.org/3320
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8ecb82c249eb887930980a800c9f87f28f861a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes