[Asterisk-code-review] codecs: Add iLBC 20. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: codecs: Add iLBC 20.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

According to the commit message iLBC 20 is now the default, but I see 30 as the default in several locations (I've marked just a couple, but others exist). Am I missing something or have it backwards?

https://gerrit.asterisk.org/#/c/3253/3/codecs/codec_ilbc.c
File codecs/codec_ilbc.c:

Line 100: 	const unsigned int mode = attr ? attr->mode : 30;
If no attr should the default be 20?


https://gerrit.asterisk.org/#/c/3253/3/res/res_format_attr_ilbc.c
File res/res_format_attr_ilbc.c:

PS3, Line 88: 		attr->mode = 30; /* optional attribute; 30 is default value */
Should the default be 20 here?


-- 
To view, visit https://gerrit.asterisk.org/3253
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07f523a3aa1338bb5217a1bf69c1eeb92adedffa
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes