[Asterisk-code-review] res pjsip mwi: fix unsolicited mwi blocks PJSIP stack (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_mwi: fix unsolicited mwi blocks PJSIP stack
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/3320/2/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 182: 
delete extraneous blank line here


Line 183: static struct ast_taskprocessor *get_mwi_serializer(void) {
guidelines curly location


Line 1217: 	ast_sip_push_task(get_mwi_serializer(), send_initial_notify_all, NULL);
Leave this one going to the pjsip/default serializer.  This way it will not block any of the new pjsip/mwi serializers.

I have a feeling that this was a culprit for one of the pjsip/default serializers getting backlogged if you have a whole lot of endpoints.  Before this patch, send_initial_notify_all() distributed all initial unsolicited MWI notifications to the pjsip/default serializers.  Since this is run by one of the pjsip/default serializers then one out of eight unsolicited MWI notifications would have to wait for this routine to complete because they would get queued to the same serializer.


Line 1262: 		ast_sip_push_task(get_mwi_serializer(), send_initial_notify_all, NULL);
Leave this one going to the pjsip/default serializer.  This way it will not block any pjsip/mwi serializers.


-- 
To view, visit https://gerrit.asterisk.org/3320
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8ecb82c249eb887930980a800c9f87f28f861a
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes