[Asterisk-code-review] astconfigparser.py: Update with realtime fixes. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: astconfigparser.py: Update with realtime fixes.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/3305/1/contrib/scripts/sip_to_pjsip/astconfigparser.py
File contrib/scripts/sip_to_pjsip/astconfigparser.py:

PS1, Line 201:     match = re.match(r'(?<!\\)(?:\\\\)*;', line)
             : 
             :     if match:
             :          # the end of where the real string is is where the escaped part is
             :          end = match.start()
             :          line = line[0:end]
Does this match, or suppose to match, on comments at the end of a line? I tried running the regex on one and it came back as None. For instance I ran line='test=123 ; comment'


-- 
To view, visit https://gerrit.asterisk.org/3305
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If229f656ef22050b50e7b34e90c4bffe796431f8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes