[Asterisk-code-review] res pjsip mwi: fix unsolicited mwi blocks PJSIP taskprocessor (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_mwi: fix unsolicited mwi blocks PJSIP taskprocessor
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/3320/1/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 1180: 	if (!(unsolicited_mwi_tps = ast_taskprocessor_get("unsolicited_mwi", 0))) {
> I want to avoid blocking pjsip task processor.
The pjsip modules have hundreds of taskprocessor/serializers.  These serializers are executed by a thread pool that you can configure in the pjsip.conf file.

Look at the usage of ast_sip_create_serializer_named().  I'd suggest using the name "pjsip/unsolicited_mwi".  If you are going to create a bunch of serializers you need to create the name using ast_taskprocessor_build_name().

Beware that using a single serializer for all these unsolicited MWI subscriptions can create its own bottle neck if the outgoing NOTIFY messages need to do a DNS lookup.  I'm not convinced this is the right solution as you created an issue with no information to see if this is the right approach.


-- 
To view, visit https://gerrit.asterisk.org/3320
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8ecb82c249eb887930980a800c9f87f28f861a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes