[Asterisk-code-review] menuselect: Various menuselect enhancements (asterisk[14])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: menuselect:  Various menuselect enhancements
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/3331/1/Makefile.moddir_rules
File Makefile.moddir_rules:

Line 167: .moduleinfo:: $(addsuffix .moduleinfo,$(addprefix .,$(sort $(ALL_C_MODS) $(ALL_CC_MODS)))) | $(wildcard $(call tolower,$(MENUSELECT_CATEGORY)).xml)
You should remove the pipe (|).  The wildcard macro filters out any files that don't exist.  Without the pipe the file will be part of $^ if it exists.


Line 170: 	@if [ -f $(call tolower,$(MENUSELECT_CATEGORY)).xml ] ; then cat $(call tolower,$(MENUSELECT_CATEGORY)).xml >> $@ ; fi
This line should be deleted.


https://gerrit.asterisk.org/#/c/3331/1/menuselect/menuselect_newt.c
File menuselect/menuselect_newt.c:

Line 329: 	memberNameTextbox       = newtTextbox(2, y - 13, x - 10, 2, NEWT_FLAG_WRAP | NEWT_FLAG_SCROLL);
This adds the textbox to the tab order.  I'd prefer we loose the NEWT_FLAG_SCROLL so it goes back to being a non-input display element. Just adding NEWT_FLAG_WRAP nearly doubles the output space.


-- 
To view, visit https://gerrit.asterisk.org/3331
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f9600a1984a42ce0696db574c1051bc9ad7c808
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes