[Asterisk-code-review] realtime: Improve test compatibility. (testsuite[master])

Joshua Colp asteriskteam at digium.com
Fri Jul 22 04:49:37 CDT 2016


Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/3214

to look at the new patch set (#3).

Change subject: realtime: Improve test compatibility.
......................................................................

realtime: Improve test compatibility.

When configuring SIP URIs in the pjsip.conf file it is
necessary to escape the semicolon so the parser does not
treat it as a comment. This change allows this to work in
the astconfigparser implementation.

A secondary bug where some data was lost if a configuration
option included a "=" in its value was also fixed.

Semi-colons are now also encoded according to how the
res_config_odbc module expects. Without this encoding they
were treated as a separator option values.

A bug where sections would be considered equal despite
being different has also been fixed.

Configuration file tests for PJSIP have also been marked
as being for configuration and a new option to runtests.py
has been added to skip a subset of tests based on tags.

Change-Id: Ibff2af1c0c4bce28b94360aecec5996f363b4ae8
---
M lib/python/asterisk/astconfigparser.py
M lib/python/asterisk/realtime_converter.py
M lib/python/asterisk/test_config.py
M runtests.py
M tests/channels/pjsip/configuration/duplicate_sections/test-config.yaml
M tests/channels/pjsip/configuration/happy_config/test-config.yaml
6 files changed, 31 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/14/3214/3
-- 
To view, visit https://gerrit.asterisk.org/3214
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibff2af1c0c4bce28b94360aecec5996f363b4ae8
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list