[Asterisk-code-review] pbx: Create pbx sw.c for management of 'struct ast sw'. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: pbx: Create pbx_sw.c for management of 'struct ast_sw'.
......................................................................


Patch Set 2:

> I'm curious why you kept ast_walk_context_switches() around. If
 > nobody is using it any longer, and this change is targeted for an
 > unrleased major version of Asterisk, it makes sense to me to just
 > outright remove it.

The same can be said for ast_walk_context_ignorepats and ast_walk_context_includes.  Honestly I'm not sure why I kept any of them in the main Asterisk source.  At this point I'm thinking a new commit to remove the 3 unused functions from 14 and master?  Or I can update this commit to remove ast_walk_context_switches then follow up with another for includes/ignorepats?

They are being left in utils/*.c because I've done bare minimum changes to keep the utils working, so those sources still use the linked list structures.

-- 
To view, visit https://gerrit.asterisk.org/3282
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08deb016df22eee8288eb03de62593e45a1f0998
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No