[Asterisk-code-review] chan sip: Prevent deadlock when issuing "sip show channels" (asterisk[certified/11.6])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: chan_sip: Prevent deadlock when issuing "sip show channels"
......................................................................


Patch Set 3:

(2 comments)

Minor nit to take advantage of the compiler's help

https://gerrit.asterisk.org/#/c/3272/3/channels/chan_sip.c
File channels/chan_sip.c:

Line 20447: 		show_chanstats_cb(cur, &arg, 0);
The function prototype should be updated to take the specific parameters instead of the generic parameters that ao2_callback requires.  Better type safety that way.


Line 20844: 		show_channels_cb(cur, &arg, 0);
same


-- 
To view, visit https://gerrit.asterisk.org/3272
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9980419909e811f89484950ed46ef117b9eb990
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: certified/11.6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes