[Asterisk-code-review] chan sip: Prevent deadlock when issuing "sip show channels" (asterisk[certified/11.6])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: chan_sip: Prevent deadlock when issuing "sip show channels"
......................................................................


Patch Set 1:

Rather than using ao2_callback() on the dialogs container use an ao2 iterator over the dialogs container that way the dialogs container is not locked while the sip_pvt is locked for processing.  There is precedent to do it this way.  Look at sip_show_channel() and sip_show_history()

Also the show_chanstats_cb has the same deadlock potential.

-- 
To view, visit https://gerrit.asterisk.org/3272
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9980419909e811f89484950ed46ef117b9eb990
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/11.6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No