[Asterisk-code-review] res pjsip pubsub: fixed a bug when pjsip tx data dec ref is ... (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/3254/3/third-party/pjproject/patches/0001-pjproject-pjsip_tx_data_dec_ref.patch
File third-party/pjproject/patches/0001-pjproject-pjsip_tx_data_dec_ref.patch:

PS3, Line 9: +    if (!atomic_var) {
           : +	return -1;
           : +    }
> It's a reasonable expectation of the API that it should never be called wit
Agree.
The exception is best if the error condition would be a sign of a serious bug, but I'd handle it somehow.
I sent the patch to upstream, so let pjproject maintainers decide what to do with it.


-- 
To view, visit https://gerrit.asterisk.org/3254
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b05917c93d993f95d604c042ace5f1a5500f59a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes