[Asterisk-code-review] pjproject: fixed a few bugs (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: pjproject: fixed a few bugs
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/3254/3/third-party/pjproject/patches/0001-pjproject-pjsip_tx_data_dec_ref.patch
File third-party/pjproject/patches/0001-pjproject-pjsip_tx_data_dec_ref.patch:

PS3, Line 9: +    if (!atomic_var) {
           : +	return -1;
           : +    }
> I agree that it's necessary to investigate further,
It's a reasonable expectation of the API that it should never be called with a NULL. You've changed it so that's allowed to fix a bug where it really shouldn't be called at all. I don't think it's a bug itself, it's just a workaround.


-- 
To view, visit https://gerrit.asterisk.org/3254
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b05917c93d993f95d604c042ace5f1a5500f59a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes