[Asterisk-code-review] pjproject: fixed a few bugs (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Wed Jul 20 12:59:29 CDT 2016


Alexei Gradinari has posted comments on this change.

Change subject: pjproject: fixed a few bugs
......................................................................


Patch Set 3:

> I'm only -1'ing until the patch is accepted upstream.
 > Alexei submitted it on 6/19.

Where is the best place to discuss this patch?
I've still hasn't received any reply to my messages to pjsip mailing list.

I think we should also replace
pj_assert( pj_atomic_get(tdata->ref_cnt) > 0);
to
if (pj_atomic_get(tdata->ref_cnt) <= 0) return PJ_SUCCESS;

-- 
To view, visit https://gerrit.asterisk.org/3254
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b05917c93d993f95d604c042ace5f1a5500f59a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list