[Asterisk-code-review] res srtp: Enable AES-256 and AES-GCM. (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_srtp: Enable AES-256 and AES-GCM.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3183/3/main/sdp_srtp.c
File main/sdp_srtp.c:

Line 94: struct ast_sdp_crypto *int_crypto_alloc(struct ast_sdp_crypto *p, const int key_len)
If this function is publicly available outside this translation unit, it needs to be prefixed with `ast_`.

If this function is local to this translation unit, it needs to be declared static.

The prefix of `int_` here also is rather odd, and doesn't match normal nomenclature used. Since this routine is now responsible for setting up the local and remote keys on an ast_sdp_crypto object, a better name might be `crypto_init_keys`.


-- 
To view, visit https://gerrit.asterisk.org/3183
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11326d80edd656524a51a19450e586c583aa0a0b
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes