[Asterisk-code-review] pbx: Create pbx include.c for management of 'struct ast incl... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: pbx: Create pbx_include.c for management of 'struct ast_include'.
......................................................................


Patch Set 4: Code-Review+1

> "That said I'm not sure how much it matters that we rescan the vector
> of pointers on each call to walk, unless someone has hundreds or
> thousands of includes to one context"

That's kinda what I was thinking/wondering too. If it does become a problem for someone in the future it can be readdressed then, but I think you have mitigated much of that anyway with the added calls.

-- 
To view, visit https://gerrit.asterisk.org/3207
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5c882e27cf96fb2aec67a39c18b4c71c9c83b60
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No