[Asterisk-code-review] func odbc: Fix connection deadlock. (asterisk[13.10])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: func_odbc: Fix connection deadlock.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/3173/1/funcs/func_odbc.c
File funcs/func_odbc.c:

PS1, Line 403: /* Some callers may provide both an obj and dsn. To ensure that
             : 		 * the connection is not released twice we set it to NULL here if
             : 		 * present.
             : 		 */
             : 		if (obj) {
             : 			*obj = NULL;
             : 		}
I'm not sure why this is necessary. The obj logic below is in an else statement, so it shouldn't be possible to be in both this block and the block below.


-- 
To view, visit https://gerrit.asterisk.org/3173
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bdbd8a300fb3233877735ad3fd07bce38115b7f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13.10
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes