[Asterisk-code-review] chan sip/res pjsip t38: Handle a request to negotiate T.38 a... (asterisk[certified/13.8])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: chan_sip/res_pjsip_t38: Handle a request to negotiate T.38 after it is enabled.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/3157/1/channels/chan_sip.c
File channels/chan_sip.c:

PS1, Line 7669: 		} else if ((p->t38.state != T38_ENABLED) || ((p->t38.state == T38_ENABLED) &&
              : 				(parameters->request_response == AST_T38_REQUEST_NEGOTIATE))) {
Can't this collapse into just an "else" clause? parameters->request_response == AST_T38_REQUEST_NEGOTIATE should always be true here, so at that point you are just checking if the state is t38 enabled or not, which should be the same as not checking the state at all.


-- 
To view, visit https://gerrit.asterisk.org/3157
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0298494d3da6df3219bbfa4be9aa04015043145c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.8
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes