[Asterisk-code-review] RFC: ao2 reference storage location logging. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: RFC: ao2 reference storage location logging.
......................................................................


Patch Set 2:

Tracking addresses of where refs are stored is going to be fragile for all but the simplest cases.  This method would not be able to track implicit reference transfers to a called function.  For example, passing a reference to a task processor callback.  This method would not be able to track references placed into a vector that then has the members shifted to keep the member order (i.e., sorted vector members).

Taking the address of a variable guarantees that it cannot be stored in a register.  Granted it won't matter in most cases and CISC processors have so few registers anyway.


It might be better to make refcounter.py able to process multi gigabyte files without choking.  One way would be to preprocess the ref log file by sorting the lines into temporary files that are then processed separately.  i.e., break the job into smaller pieces.

-- 
To view, visit https://gerrit.asterisk.org/3141
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb0a51cefaa98c83eab18aa2b7d18850bb33951
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No