[Asterisk-code-review] res pjsip: Added "subscribe context" to endpoint (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Added "subscribe_context" to endpoint
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

In the case of other places there's already stringfields so storing the context that way can actually be helpful memory usage wise. For subscribe_context there's none as of this time, so I think something of a fixed size using AST_MAX_CONTEXT is perfect.

https://gerrit.asterisk.org/#/c/3145/3/res/res_pjsip_exten_state.c
File res/res_pjsip_exten_state.c:

Line 355: 	const char *context=S_OR(endpoint->subscription.context, endpoint->context);
Spaces before and after =


-- 
To view, visit https://gerrit.asterisk.org/3145
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fb7a15f5bc154079bd348c08b7ad1cdd2d5e514
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes