[Asterisk-code-review] pjsip: Added "subscribe context" to endpoint (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: pjsip: Added "subscribe_context" to endpoint
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

This is a new feature in 13 and also requires a test before being included.

https://gerrit.asterisk.org/#/c/3145/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 502: 		AST_STRING_FIELD(context);
Contexts have a fixed maximum size so I don't think this needs to have the overhead of stringfields yet.


https://gerrit.asterisk.org/#/c/3145/1/res/res_pjsip_exten_state.c
File res/res_pjsip_exten_state.c:

Line 355: 	const char *context=(ast_strlen_zero(endpoint->subscription.context)?endpoint->context:endpoint->subscription.context);
This should use S_OR:

S_OR(endpoint->subscription.context, endpoint->context)


Line 377: 	ast_copy_string(exten_state_sub->context,
Same here.


-- 
To view, visit https://gerrit.asterisk.org/3145
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fb7a15f5bc154079bd348c08b7ad1cdd2d5e514
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes