[Asterisk-code-review] res sorcery realtime: fix bug when successful UPDATE is trea... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Mon Jul 4 17:30:37 CDT 2016


Alexei Gradinari has posted comments on this change.

Change subject: res_sorcery_realtime: fix bug when successful UPDATE is treated as failed
......................................................................


Patch Set 1:

[test_sorcery_realtime.c:object_update_uncreated:742]: Successfully updated an object which has not been created yet.

On the one hand this test can be considered correct, but on the other hand... how can we know if there wasn't record to modify or the record existed but wasn't updated because nothing changed?

-- 
To view, visit https://gerrit.asterisk.org/3146
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05a7f3051455336c9dda29efc229decf86071303
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list