[Asterisk-code-review] Make tests SILK-ready. (testsuite[master])

Mark Michelson asteriskteam at digium.com
Fri Jul 1 14:17:22 CDT 2016


Mark Michelson has uploaded a new change for review.

  https://gerrit.asterisk.org/3140

Change subject: Make tests SILK-ready.
......................................................................

Make tests SILK-ready.

Addition of SILK understanding to the SDP code has made it so that
Asterisk can now respond to SILK offers. This means the old single audio
stream basic test fails since it does not expect for Asterisk to respond
with SILK payloads.

This commit fixes the issue by splitting the existing test based on
version numbers. Once past 13.11.0, an alternate version of the
uac-all-codecs.xml file is used. In this alternate version, we expect
Asterisk to include SILK payloads in the SDP response.

Change-Id: I72fadf35d4385db0195f2ac7a65611c186e1bda3
---
M tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/test-config.yaml
1 file changed, 25 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/40/3140/1

diff --git a/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/test-config.yaml b/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/test-config.yaml
index 0ca45d8..ecac231 100644
--- a/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/test-config.yaml
+++ b/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/test-config.yaml
@@ -25,7 +25,12 @@
 
 test-modules:
     test-object:
+        maxversion: '13.11.0'
         config-section: test-object-config
+        typename: 'sipp.SIPpTestCase'
+    test-object:
+        minversion: '13.11.0'
+        config-section: test-object-config-13-11
         typename: 'sipp.SIPpTestCase'
 
 test-object-config:
@@ -47,6 +52,26 @@
             scenarios:
                 - { 'key-args': {'scenario': 'uac-basic-codecs-delayed.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice-codec-match', } }
 
+test-object-config-13-11:
+    reactor-timeout: 80
+    fail-on-any: False
+    test-iterations:
+        -
+            scenarios:
+                - { 'key-args': {'scenario': 'uac-all-codecs-13-11.xml', '-i': '127.0.0.1', '-p': '5062', '-s': 'alice-codec-all', } }
+                - { 'key-args': {'scenario': 'uac-basic-codecs.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice-codec-match', } }
+                - { 'key-args': {'scenario': 'uac-basic-codecs.xml', '-i': '127.0.0.1', '-p': '5063', '-s': 'alice-codec-extended', } }
+        -
+            scenarios:
+                - { 'key-args': {'scenario': 'uac-basic-codecs-no-rtpmap.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice-codec-match', } }
+        -
+            scenarios:
+                - { 'key-args': {'scenario': 'uac-basic-codecs-odd-rtpmap.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice-codec-match', } }
+        -
+            scenarios:
+                - { 'key-args': {'scenario': 'uac-basic-codecs-delayed.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice-codec-match', } }
+
+
 properties:
     minversion: '13.0.0'
     dependencies:

-- 
To view, visit https://gerrit.asterisk.org/3140
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72fadf35d4385db0195f2ac7a65611c186e1bda3
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list