[Asterisk-code-review] Implement deaf mode for confbridge (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: Implement deaf mode for confbridge
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2933/4/apps/app_confbridge.c
File apps/app_confbridge.c:

PS4, Line 481: 	case CONF_SOUND_DEAFENED:
             : 		return S_OR(custom_sounds->deafened, "conf-deafened");
             : 	case CONF_SOUND_UNDEAFENED:
             : 		return S_OR(custom_sounds->undeafened, "conf-undeafened");
Where are these sound files? Currently they won't exist in a user's asterisk sounds directory. Will the missing sound files cause any potential problems?

I'm guessing any new sound file(s) will have to go out in a new sounds release? Someone else with more info about this may wish to comment.


-- 
To view, visit https://gerrit.asterisk.org/2933
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2628bdda080fd2b1e914212de50dd26de9d3e96
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Timo Teräs <timo.teras at iki.fi>
Gerrit-HasComments: Yes