[Asterisk-code-review] chan sip: Fix lastrtprx always updated (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip: Fix lastrtprx always updated
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/3032/3//COMMIT_MSG
Commit Message:

Line 9: lastrtprx always updated and therefore rtptimeout doesn't work at all
I think this should include a description like the one in the comments to describe in what cases we'd be called. As it is this commit message doesn't provide useful information for someone who may be looking through.


Line 11: ASTERISK-25270
Since this fixes the issue it should have a #close tag at the end:

ASTERISK-25270 #close


-- 
To view, visit https://gerrit.asterisk.org/3032
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3b5ca0dbb822582a86eb7d01dcae4e83448c41d
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Evgeniy Tsybra <cjack at yandex.ru>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Evgeniy Tsybra <cjack at yandex.ru>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes