[Asterisk-code-review] build system: Prevent goals needing makeopts from running wh... (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: build_system: Prevent goals needing makeopts from running when it's missing
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2100/1/Makefile
File Makefile:

Line 101: # makeopts is required unless the goal is clean or distclean
        : ifeq ($(findstring clean,$(MAKECMDGOALS)),)
        : include makeopts
        : endif
This just makes the failure to include makeopts not silent.  Make continues on anyway and since uninstall has no dependency on makeopts it will still try to delete the contents of the root directory.

Since you cannot uninstall when make has no idea where Asterisk was installed without makeopts, you should just add makeopts as the first dependency of the _uninstall target/goal.

_uninstall: makeopts $(SUBDIRS_UNINSTALL) main-binuninstall


-- 
To view, visit https://gerrit.asterisk.org/2100
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bce59a7ea4f48e7a468e22b2abbb13c63417ac7
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes