[Asterisk-code-review] res rtp asterisk: Allow ICE host candidates to be overriden (asterisk[13])

Mark Michelson asteriskteam at digium.com
Thu Jan 28 10:28:27 CST 2016


Mark Michelson has posted comments on this change.

Change subject: res_rtp_asterisk: Allow ICE host candidates to be overriden
......................................................................


Patch Set 3:

> All right, if you're not using STUN then srflx addresses would not
 > be discovered, so using those as a replacement for private
 > addresses makes sense. The only potential problem I have is that if
 > you advertise a srflx candidate as a host candidate, does that
 > potentially cause issues during ICE negotiation? I suspect it would
 > not, but I figure it doesn't hurt to ask.

I talked with Sean and Josh on IRC about this. We're in a position where we think that it's probably fine to advertise a public NAT address as a host candidate in a 1-to-1 situation like Sean is describing.

-- 
To view, visit https://gerrit.asterisk.org/2101
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c9541af97b83a4c690c8150d19bf7202c8bff1f
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list