[Asterisk-code-review] config: Allow options to register when documentation is unav... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: config: Allow options to register when documentation is unavailable.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2077/1/main/config_options.c
File main/config_options.c:

Line 721: 	if (opt->doc_unavailable) {
        : 		ast_log(LOG_ERROR, "Config option '%s' of type '%s' is not completely documented and can not be set\n", var->name, type->name);
        : 		return -1;
        : 	}
> Yeah, we're in that blurry area between enforcement for a developer and end
I tend to think about the case where the bug was initially discovered, and then think about what's reasonable for that case.

In my opinion, the fact that the deployment of Asterisk did not have up-to-date documentation for the configuration option should neither stop the default value from being set, nor should it stop the user from attempting to set the value. I'm in agreement that failure to set the option should only happen in dev mode.


-- 
To view, visit https://gerrit.asterisk.org/2077
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec42fca6b35f31326c33fcdc25473f6fd7bc8af8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes