[Asterisk-code-review] Stasis: Use custom structure when setting variables. (asterisk[13])

Mark Michelson asteriskteam at digium.com
Tue Jan 26 10:23:45 CST 2016


Mark Michelson has posted comments on this change.

Change subject: Stasis: Use custom structure when setting variables.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2076/1/res/stasis/control.c
File res/stasis/control.c:

Line 655: 	struct ast_variable *var = data;
> I'd update this to be struct chanvar just in case the layout changes...
Wow, that's a bad mistake.


-- 
To view, visit https://gerrit.asterisk.org/2076
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I784d7beaaa3c036ea936d103e7caf0bb1562162d
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list